site start does not run same preflight checks as site enable
To recreate
- Don’t expose your hostname
- Run
site enable
- Note server refuses to start as hostname is not reachable (correct behaviour)
- Start ngrok
- Run
site enable
- Note server starts as hostname is reachable (correct behaviour)
- Run
site stop
- Stop ngrok
- Run
site start
What should happen
Site.js should refuse to start the server as the hostname is not reachable.
What actually happens
Site.js starts the server even though it is not reachable and even thought we haven’t specified the --skip-domain-reachability-check
flag.